Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dlang Collie #2627

Merged
merged 9 commits into from Apr 15, 2017
Merged

Add Dlang Collie #2627

merged 9 commits into from Apr 15, 2017

Conversation

dushibaiyu
Copy link
Contributor

No description provided.

@NateBrady23
Copy link
Member

@dushibaiyu Thanks for the contribution! A few things to start. Please add:
- "TESTDIR=D/collie"
to the .travis.yml file in the project root. Also, please include a README.md similar to this one so we can get some more information about the framework.

@@ -0,0 +1,12 @@
#!/bin/bash

fw_depends dlang dub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watch out for the #2648 as it removes the dub systool (as it is installed with dmd already). So if it gets merged, this needs to be updated too.

@dushibaiyu
Copy link
Contributor Author

updated

@NateBrady23
Copy link
Member

@dushibaiyu Thank you! We are seeing failures on Travis now. Please take a look when you can. Thanks!

setup.sh: line 10: dub: command not found
@dushibaiyu
Copy link
Contributor Author

it can not find dub.
maybe I should add dub in step.sh

@tchaloupka
Copy link
Contributor

From the travis build log when it fails previously, it was because then the #2648 was not merged yet so there was the older dmd without dub packaged in it.

See:

Setup Collie: +++DMDVER=2.071.1

Setup Collie: +++LDCVER=1.0.0

Setup Collie: +++mkdir -p /home/travis/build/TechEmpower/FrameworkBenchmarks/installs/dlang

Setup Collie: +++fw_get -O http://downloads.dlang.org/releases/2.x/2.071.1/dmd_2.071.1-0_amd64.deb

Setup Collie: +++curl -sL -O http://downloads.dlang.org/releases/2.x/2.071.1/dmd_2.071.1-0_amd64.deb
...

Now it is merged so there is no need to depend on dub in the setup. See current build log for vibe: https://travis-ci.org/TechEmpower/FrameworkBenchmarks/jobs/218750261

@dushibaiyu
Copy link
Contributor Author

update, and wait test

@tchaloupka
Copy link
Contributor

@nbrady-techempower this seems ok now, error in travis is unrelated

@NateBrady23
Copy link
Member

@tchaloupka It's possible that if I merge this in now it will get in to Round 14 final without the chance for you to see any preview data. I can wait until after Round 14 is complete or I can get this in now.. Up to you.

@NateBrady23
Copy link
Member

Looks like it may have missed the cutoff for final, but will get this in nonetheless.

@NateBrady23 NateBrady23 merged commit 1cd08d6 into TechEmpower:master Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants