New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dlang Collie #2627
Add Dlang Collie #2627
Conversation
@dushibaiyu Thanks for the contribution! A few things to start. Please add: |
frameworks/D/collie/setup.sh
Outdated
@@ -0,0 +1,12 @@ | |||
#!/bin/bash | |||
|
|||
fw_depends dlang dub |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Watch out for the #2648 as it removes the dub systool (as it is installed with dmd already). So if it gets merged, this needs to be updated too.
updated |
@dushibaiyu Thank you! We are seeing failures on Travis now. Please take a look when you can. Thanks! |
setup.sh: line 10: dub: command not found
it can not find dub. |
From the travis build log when it fails previously, it was because then the #2648 was not merged yet so there was the older dmd without dub packaged in it. See:
Now it is merged so there is no need to depend on dub in the setup. See current build log for vibe: https://travis-ci.org/TechEmpower/FrameworkBenchmarks/jobs/218750261 |
update, and wait test |
@nbrady-techempower this seems ok now, error in travis is unrelated |
@tchaloupka It's possible that if I merge this in now it will get in to Round 14 final without the chance for you to see any preview data. I can wait until after Round 14 is complete or I can get this in now.. Up to you. |
Looks like it may have missed the cutoff for final, but will get this in nonetheless. |
No description provided.