palemoon: 27.1.1 -> 27.2.1 #24402
palemoon: 27.1.1 -> 27.2.1 #24402
Conversation
|
@calvertvl, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rnhmjoj and @bjornfor to be potential reviewers. |
|
|
||
| src = fetchFromGitHub { | ||
| name = "palemoon-src"; | ||
| owner = "MoonchildProductions"; | ||
| repo = "Pale-Moon"; | ||
| rev = "a35936746069e6591181eb67e5f9ea094938bae5"; | ||
| rev = version + "_Release"; | ||
| sha256 = "0hns5993dh93brwz3z4xp1zp8n90x1hajxylv17zybpysax64jsk"; |
There was a problem hiding this comment.
won't this bit break?
There was a problem hiding this comment.
No, it's fine. See how the release are tagged: https://github.com/MoonchildProductions/Pale-Moon/releases
There was a problem hiding this comment.
@rnhmjoj i meant the unchanged content hash making it confuse wrt the fixed output derivation
There was a problem hiding this comment.
The version+"_Release" bit builds the tag name; these can be used when fetching from git.
It's also a bit more obvious than just using a hash.
|
While you are at it can you fix the desktop entry? to the install phase. |
Also adding fix for desktop entry.
calvertvl
force-pushed
the
update-palemoon-27_2_1
branch
from
c4146ca
to
de02dfc
Compare
|
Pushed the updated version, with the desktop entry fix from @rnhmjoj; it actually picks up the correct version of the source code this time. |
Motivation for this change
Version bump.
Also a bit of whitespace cleanup, and refactoring to use release tags.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)