Fix: OpenSSL 1.1.0 #4230
Merged
Fix: OpenSSL 1.1.0 #4230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sk_free => OPENSSL_sk_free - sk_num => OPENSSL_sk_num - sk_pop_free => OPENSSL_sk_pop_free - sk_value => OPENSSL_sk_value - evp_md_ctx_create => evp_md_ctx_new - evp_md_ctx_destroy => evp_md_ctx_free
|
Looks like there are two specs to remove for |
ysbaddaden
force-pushed
the
std-fix-openssl-110
branch
from
2154718
to
fdd8594
Compare
ysbaddaden
force-pushed
the
std-fix-openssl-110
branch
from
fdd8594
to
58b8481
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSSL 1.1.0 renamed some libcrypto symbols (eg:
sk_*toOPENSSL_sk_*), and dropped support for DSS. I chose to drop DSS, too, for the principle of least suprise —a binary built against OpenSSL 1.0 would fail to run if OpenSSL is upgraded to 1.1.This allows to build the Crystal test suite against OpenSSL 1.1.0.
closes #4204