epdfview: Fixed SRC URL; Cosmetic Change #24568
Conversation
|
What happened to the old upstream? |
|
@joachifm I tried the old url to check for a newer version and seems it no longer exists |
| @@ -4,11 +4,12 @@ stdenv.mkDerivation rec { | |||
| name = "epdfview-0.1.8"; | |||
|
|
|||
| src = fetchurl { | |||
| url = "http://trac.emma-soft.com/epdfview/chrome/site/releases/${name}.tar.bz2"; | |||
| sha256 = "1w7qybh8ssl4dffi5qfajq8mndw7ipsd92vkim03nywxgjp4i1ll"; | |||
| url = "http://http.debian.net/debian/pool/main/e/epdfview/epdfview_0.1.8.orig.tar.gz"; | |||
There was a problem hiding this comment.
Consider using mirror://debian instead. Also, consider factoring out the version.
|
I see. When changing upstreams, it's good to mention why. Debian is a trusted source, ofc. but in general it's a little suspicious :) |
|
@joachifm WIll try to remember to add that as a PR note then :) or commit |
|
In general, mentioning stuff like that in the commit message is probably best. I, at least, find it more convenient than having to track down review comments on github. |
|
|
||
| src = fetchurl { | ||
| url = "http://trac.emma-soft.com/epdfview/chrome/site/releases/${name}.tar.bz2"; | ||
| sha256 = "1w7qybh8ssl4dffi5qfajq8mndw7ipsd92vkim03nywxgjp4i1ll"; | ||
| url = "mirror://debian/epdfview/epdfview_${version}.orig.tar.gz"; |
There was a problem hiding this comment.
I believe you need to include the /pool/whatever stuff in the url when using the debian mirrors.
epdfview: Updated Debian Mirror
|
@joachifm FIxed |
(cherry picked from commit 969ed88) Upstream has disappeared.
Motivation for this change
Cosmetic
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)