git-cola: 2.8 -> 2.10 #24552
Merged
git-cola: 2.8 -> 2.10 #24552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bobvanderlinden and @FRidh to be potential reviewers. |
|
Looks good. By the way, I think wrapPythonPrograms is called twice, once in the |
git-cola: Remove postFixup
|
@FRidh I removed postFixup, though not sure if it was the correct thing to do or not; from what I can tell git-cola works but see if you think it shouldn't have been done? |
|
Apparently the problem with Nix's wrapping and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)