Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt58: Fix path to qhelpgenerator in cmake file. #24558

Merged
merged 1 commit into from Apr 5, 2017
Merged

Conversation

ambrop72
Copy link
Contributor

@ambrop72 ambrop72 commented Apr 2, 2017

It is located in the dev output, fix it as for qcollectiongenerator.
This fixes a build error in KDevelop.

Motivation for this change

Build error in KDevelop (Hydra doesn't show the log for some reason). It is because the path in the installed cmake file to qhelpgenerator is wrong, it points to the default output but the binary is in the dev output.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

It is located in the dev output, fix it as for qcollectiongenerator.
This fixes a build error in KDevelop.
@mention-bot
Copy link

@ambrop72, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ttuegel to be a potential reviewer.

@vcunat vcunat merged commit 195efed into NixOS:master Apr 5, 2017
vcunat added a commit that referenced this pull request Apr 5, 2017
@dotlambda
Copy link
Member

Result of nixpkgs-review pr 24558 run on x86_64-linux 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants