Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lightdm: 1.18.1 -> 1.22.0 #24545

Merged
merged 1 commit into from Apr 2, 2017
Merged

lightdm: 1.18.1 -> 1.22.0 #24545

merged 1 commit into from Apr 2, 2017

Conversation

ndowens
Copy link
Contributor

@ndowens ndowens commented Apr 1, 2017

Motivation for this change

Update

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @wkennington, @obadz and @NeQuissimus to be potential reviewers.

@obadz
Copy link
Contributor

obadz commented Apr 2, 2017

Worked for me!

@obadz obadz merged commit 7d076ab into NixOS:master Apr 2, 2017
@obadz
Copy link
Contributor

obadz commented Apr 2, 2017

hmmm @ndowens, how did you get comfortable that the patch was no longer required?

@ndowens
Copy link
Contributor Author

ndowens commented Apr 2, 2017 via email

@obadz
Copy link
Contributor

obadz commented Apr 2, 2017

Ok I guess let's go with it in master for now…

@obadz
Copy link
Contributor

obadz commented Apr 2, 2017

@wkennington, looks like you authored the patch in 3988cfc. Feel free to opine :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants