Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix geoclue build on macOS #24546

Merged
merged 1 commit into from Apr 6, 2017
Merged

Fix geoclue build on macOS #24546

merged 1 commit into from Apr 6, 2017

Conversation

hamishmack
Copy link
Contributor

Motivation for this change

geoclue (needed by WebKitGTK+) did not build on MacOS

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@hamishmack, thanks for your PR! By analyzing the history of the files in this pull request, we identified @garbas, @nckx and @Profpatsch to be potential reviewers.

@hamishmack hamishmack mentioned this pull request Apr 1, 2017
Closed
7 tasks
matthewbauer
matthewbauer approved these changes Apr 2, 2017
View reviewed changes
Copy link
Member

@matthewbauer matthewbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds correctly for me!

@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Apr 6, 2017
@LnL7
Copy link
Member

LnL7 commented Apr 6, 2017

Does something similar work for 1.x?

@Profpatsch Profpatsch merged commit bde6e3d into NixOS:master Apr 6, 2017
@hamishmack hamishmack deleted the geoclue-macos2 branch April 7, 2017 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hamishmack @mention-bot @LnL7 @matthewbauer @Profpatsch @Janik-Haag