Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iterm2: 3.0.4 -> 3.0.14 + fix build #24313

Merged
merged 1 commit into from Mar 25, 2017
Merged

iterm2: 3.0.4 -> 3.0.14 + fix build #24313

merged 1 commit into from Mar 25, 2017

Conversation

womfoo
Copy link
Member

@womfoo womfoo commented Mar 25, 2017

Motivation for this change
  • update to latest stable release + fix build
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@womfoo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mpscholten to be a potential reviewer.

@joachifm
Copy link
Contributor

Darwin build fails: https://travis-ci.org/NixOS/nixpkgs/jobs/214936870, is that expected?

@womfoo
Copy link
Member Author

womfoo commented Mar 25, 2017

works for me when built locally

==> Creating nixpkgs repo in /Users/ipscape-kranium/.nox/nixpkgs
==> We're in a git repo, trying to fetch it
Building in /var/folders/zk/2znm_96n6bx749h8wn5n3cgh0000gn/T/nox-review-hpyqbh7a: iterm2
/nix/store/signk7vnqbz2jh1zn9xkj4p4r6n94kyk-iterm2-3.0.14
Result in /var/folders/zk/2znm_96n6bx749h8wn5n3cgh0000gn/T/nox-review-hpyqbh7a
total 4
lrwxr-xr-x 1 ipscape-kranium staff 57 Mar 25 23:25 result -> /nix/store/signk7vnqbz2jh1zn9xkj4p4r6n94kyk-iterm2-3.0.14

@womfoo
Copy link
Member Author

womfoo commented Mar 25, 2017

macports hit the same error in https://trac.macports.org/ticket/51983. could travis have an older toolchain in the environment?

im on OSX Sierra 10.12.3 (16D32) btw

@joachifm
Copy link
Contributor

@womfoo if you can build it locally, I'd trust that over travis :) I guess we'll see once it hits Hydra.

@joachifm joachifm merged commit 69a169e into NixOS:master Mar 25, 2017
@womfoo womfoo deleted the bump/iterm2-3.0.14 branch April 30, 2017 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@womfoo @mention-bot @joachifm