Flate: try to inflate even if @stream.avail_in is 0 #4193
Merged
+20
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix crystal-lang#4192 Probably LibZ::Error::STREAM_END is only way to detect the end of a stream.
|
Hmm... Is |
|
@makenowjust yep, it seems there sth wrong with |
bcardiff
added
kind:bug
|
Thanks @makenowjust the refactor brought back some corner cases again ... |
|
and thanks for the quick response and fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4192
We cannot assume the end of a stream even if
@stream.avail_inis0.z_stream's internal state may have more outputs, #4192 for example. ProbablyLibZ::Error::STREAM_ENDis only way to detect the end of a stream.