Adds non-allocating random_bytes method to SecureRandom. Fixes #4049 #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Mar 24, 2017
src/secure_random.cr
Outdated
| @@ -69,20 +69,31 @@ module SecureRandom | |||
| if n < 0 | |||
| raise ArgumentError.new "Negative size: #{n}" | |||
| end | |||
| buf = Bytes.new(n) | |||
There was a problem hiding this comment.
You could rewrite it to:
Bytes.new(n).tap { |buf| random_bytes(buf) }
ysbaddaden
requested changes
Mar 27, 2017
| @@ -92,7 +101,7 @@ module SecureRandom | |||
| @@initialized = true | |||
|
|
|||
| {% if flag?(:linux) %} | |||
| if getrandom(Bytes.new(16)) >= 0 | |||
| if sys_getrandom(Bytes.new(16)) >= 0 | |||
There was a problem hiding this comment.
This should still call `getrandom, even for 16 bytes. Maybe we could only read 2 bytes at first.
There was a problem hiding this comment.
Well, i've saved an old behaviour:
before commit was 1:getrandom(Bytes):Int that returns number of bytes and 2:getrandom(Int):Bytes that wraps (1) for arbitrary size.
Now (2) has signature getrandom(Bytes):Nil, so (1) is renamed to sys_getrandom(Bytes) to avoid conflict. Here we are checking if getrandom syscall is supported, so sys_getrandom seems right function for me.
ysbaddaden
approved these changes
Mar 28, 2017
|
Thanks @konovod ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4049.
I thought that there is a #3434 so i should wait until it is checked, but now i spotted labels so i think this PR should be done.