Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitkraken: 2.2.0 -> 2.2.1 #24301

Merged
merged 1 commit into from Mar 24, 2017
Merged

gitkraken: 2.2.0 -> 2.2.1 #24301

merged 1 commit into from Mar 24, 2017

Conversation

winniequinn
Copy link
Contributor

Motivation for this change
  • Version bump.
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -6,11 +6,11 @@

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put: with stdenv.lib; at top and remove stdenv.lib through out the nix file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done as requested!

@joachifm joachifm merged commit 872a15a into NixOS:master Mar 24, 2017
@winniequinn winniequinn deleted the gitkraken-2.2.1 branch May 27, 2017 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants