Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify UEFI bootloader setup #24304

Merged
merged 1 commit into from Mar 25, 2017

Conversation

matklad
Copy link
Member

@matklad matklad commented Mar 24, 2017

Motivation for this change

Clarify place in the docs which confused me.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Hi! I've recently installed NixOS on UEFI and was confused by the docs which said

You must set the option boot.loader.grub.device.

It's not the case for UEFI, so let's say this more explicitelly?

@mention-bot
Copy link

@matklad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @thatdocslady, @edolstra and @wlhlm to be potential reviewers.

@cillianderoiste cillianderoiste merged commit 170b8da into NixOS:master Mar 25, 2017
@cillianderoiste
Copy link
Member

Excellent, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants