Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 61b5bb7b2453
Choose a base ref
...
head repository: mockingbirdnest/Principia
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f6277e8bc5c6
Choose a head ref
  • 4 commits
  • 1 file changed
  • 2 contributors

Commits on Mar 24, 2017

  1. Rename the body-centred-body-direction frame

    @eggrobin
    eggrobin committed Mar 24, 2017
    Copy the full SHA
    194836c View commit details

  2. swapped FATAL messages

    @eggrobin
    eggrobin committed Mar 24, 2017
    Copy the full SHA
    cb1ff5c View commit details

  3. that was the TODO

    @eggrobin
    eggrobin committed Mar 24, 2017
    Copy the full SHA
    f272cb7 View commit details

Commits on Mar 25, 2017

  1. Merge pull request #1285 from eggrobin/rename-frame 

    Rename the body-centred-body-direction frame
    @pleroy
    pleroy authored Mar 25, 2017
    Copy the full SHA
    f6277e8 View commit details
Showing with 5 additions and 6 deletions.
  1. +5 −6 ksp_plugin_adapter/reference_frame_selector.cs
11 changes: 5 additions & 6 deletions ksp_plugin_adapter/reference_frame_selector.cs
View file
Original file line number Diff line number Diff line change
@@ -77,9 +77,8 @@ public static String Name(FrameType type, CelestialBody selected) {
throw Log.Fatal(
"Naming parent-direction rotating frame of root body");
} else {
// TODO(egg): find a proper name...
return selected.name + "-Centred " + selected.referenceBody.name +
"-Fixed";
"-Aligned";
}
case FrameType.BODY_SURFACE:
return selected.name + "-Centred " + selected.name + "-Fixed";
@@ -94,17 +93,17 @@ public static String ShortName(FrameType type, CelestialBody selected) {
return selected.name[0] + "CI";
case FrameType.BARYCENTRIC_ROTATING:
if (selected.is_root()) {
throw Log.Fatal(
"Naming parent-direction rotating frame of root body");
throw Log.Fatal("Naming barycentric rotating frame of root body");
} else {
return selected.referenceBody.name[0] + (selected.name[0] + "B");
}
case FrameType.BODY_CENTRED_PARENT_DIRECTION:
if (selected.is_root()) {
throw Log.Fatal("Naming barycentric rotating frame of root body");
throw Log.Fatal(
"Naming parent-direction rotating frame of root body");
} else {
return selected.name[0] + "C" + selected.referenceBody.name[0] +
"F";
"A";
}
case FrameType.BODY_SURFACE:
return selected.name[0] + "C" + selected.name[0] + "F";