Change Plugin and Celestial to operate on rotating bodies instead of massive bodies. #1286
+280
−145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
requested changes
Mar 25, 2017
ksp_plugin/plugin.cpp
Outdated
| dynamic_cast_not_null<RotatingBody<Barycentric> const*>( | ||
| system.bodies[i].release()); | ||
| std::unique_ptr<RotatingBody<Barycentric> const> owned_body(unowned_body); | ||
| Index const celestial_index = bodies_to_indices[unowned_body]; |
There was a problem hiding this comment.
overload dynamic_cast_not_null for std::unique_ptr
eggrobin
approved these changes
Mar 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
physicslayer still operates on massive bodies, so a few conversions are needed when crossing fromksp_plugintophysicsand back.Fix #1112.