Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util-linux: fix path to umount in eject #25056

Merged
merged 1 commit into from Apr 20, 2017

Conversation

lheckemann
Copy link
Member

@lheckemann lheckemann commented Apr 20, 2017

Motivation for this change

#24456

Things done

I have not tested this change because it causes a huge amount of rebuilds for me.

  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@copumpkin
Copy link
Member

Can you repoint this at staging if it's a mass rebuild?

@lheckemann lheckemann changed the base branch from master to staging April 20, 2017 14:55
@lheckemann
Copy link
Member Author

Done!

@Mic92 Mic92 merged commit 7c75ef8 into NixOS:staging Apr 20, 2017
@lheckemann lheckemann deleted the fix-eject-umount branch April 20, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants