PICARD-1065: Fix patch_version #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zas
requested changes
Apr 10, 2017
setup.py
Outdated
| @@ -584,7 +584,7 @@ def run(self): | |||
|
|
|||
| def patch_version(self, filename): | |||
| regex = re.compile(r'^PICARD_BUILD_VERSION_STR\s*=.*$', re.MULTILINE) | |||
| with open(filename, 'r+b') as f: | |||
There was a problem hiding this comment.
Doing so will possibly change end of lines of the read then written file. Instead if i think we should keep binary mode, but convert source to unicode.
zas
approved these changes
Apr 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tickets.metabrainz.org/browse/PICARD-1065