lib: trivial spelling fixes #25031
Merged
lib: trivial spelling fixes #25031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joachifm
reviewed
Apr 19, 2017
lib/lists.nix
Outdated
| @@ -148,7 +148,7 @@ rec { | |||
| let found = filter pred list; | |||
| in if found == [] then default else head found; | |||
|
|
|||
| /* Return true iff function `pred' returns true for at least element | |||
There was a problem hiding this comment.
"iff" is a short-hand for "if and only if" (using just "if" here suggests that the function could return true in other cases as well)
|
Having scanned it briefly, looks okay to me apart from the |
|
Ok I will fix the iff's
On Apr 19, 2017 5:28 PM, "Joachim F." <notifications@github.com> wrote:
Having scanned it briefly, looks okay to me apart from the iff -> if
change, which is incorrect.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25031 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAbykbzQ7Zt-n_CXFBPakaRamNEx5SoZks5rxoqkgaJpZM4NCMRB>
.
|
|
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Noticed spelling errors in lib file, then found as many other spelling errors in lib.
Things done
Found sorted list of "bad" words from aspell.
cat lib/*.nix |aspell list |sort |uniq -c |sort -nr > spells.txt
Went through the generated file and found a few more spelling errors in lib.
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)