Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: crystal-lang/crystal
base: c49cf6146126
Choose a base ref
...
head repository: crystal-lang/crystal
compare: f40bcb3f6ba7
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Apr 19, 2017

  1. WeakRef: Do not register non heap pointers as diasappearing links 

    This should allow at least pointers to the data section
to work seamlessly with WeakRef and in some cases even
allow stack pointers to be passed, for the crazy
    @jhass @bcardiff
    jhass authored and bcardiff committed Apr 19, 2017
    Copy the full SHA
    8b0fd63 View commit details
    Browse the repository at this point in the history

  2. Rename WeakRef#target to WeakRef#value 

    value is consistent with pointer

Additionally target feels like it's leaking implementation details as
that's the name of the internal instance variable too
    @jhass @bcardiff
    jhass authored and bcardiff committed Apr 19, 2017
    Copy the full SHA
    f40bcb3 View commit details
    Browse the repository at this point in the history