-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Darwin->Darwin cross support #25047
Conversation
@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @bgamari, @aszlig, @LnL7 and @copumpkin to be potential reviewers. |
This looks like it's a mass-rebuild? Definitely should go into staging first then. |
Only for cross. Native hashes are unchanged. It would be prettier of it were a mass rebuild :). |
It would be helpful, if you can't split this up further, if you summarized what you changed and why. It's pretty hard to review 1200+ lines of diff changing all sorts of core behavior in difficult-to-follow ways. |
Or if there's a high-level description of why and the new design, that would also help. A giant mass of code changing core stdenv stuff is hard though 😄 |
I'll split off the first few lib changes. Those are easy cause they don't change any hashes. In the rest, turns out I am getting a native rebuild which is very odd. I'll beef up commit messages etc while fixing that. Sorry for the jumble, but I wrote all these changes very hastily to begin with 😁. |
583e5cb
to
edd68ad
Compare
Split out #25099, which is merged. edit merged. |
2bd38bd
to
733b9cd
Compare
Split out tiny cleanup #25186 which also doesn't change any hashes. |
Split out #25194, which redefines |
e9247e6
to
32bf1b8
Compare
http://hydra.nixos.org/jobset/nixpkgs/pr-25047 for regression test. |
9955cb7
to
d8405ad
Compare
So how do you test on Darwin? I've tried:
|
@matthewbauer Uh I was using this in conjunction with @shlevy's impure iOS stuff on darwin. As I found when I added the last commit adding some darwin tests, more work will be needed to test end-to-end purely :(. I'll get to that, though. If you want, try building |
After slaving away to make it hash-preserving I peeled off #25227 with...the first commit. It's a lot of work to make something hash preserving, but whenever I go for it I inevitably find a real bug. edit merged. |
d4b8e7c
to
2fa5785
Compare
2fa5785
to
bed4256
Compare
bed4256
to
37b470a
Compare
5c6948c
to
53d390c
Compare
2b76a7f
to
aab307d
Compare
aab307d
to
ea112e7
Compare
ea112e7
to
b7b2295
Compare
b7b2295
to
acb4300
Compare
acb4300
to
e5574dd
Compare
Any update on this pull request? |
Closing due to lack of activity, feel free to reopen this if needed. |
Motivation for this change
First batch of cleaned-up up history from #24983 (comment)
Should not change any native hashes, but may break some Haskell cross compiling --- I hope that's OK otherwise there's just going to be too much to merge at once.
Depends on #25044 for testing on darwin.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandbox
innix.conf
on non-NixOS)
nix-shell -p nox --run "nox-review wip"
./result/bin/
)