Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slight tweak to assign wedge bonds. #300

Merged
merged 3 commits into from Apr 20, 2017
Merged

Slight tweak to assign wedge bonds. #300

merged 3 commits into from Apr 20, 2017

Conversation

johnmay
Copy link
Member

@johnmay johnmay commented Apr 19, 2017

Nope..
image
image

Yep (although not optimal -> the terminal bonds should be vertical for steroids)..
image

egonw
egonw requested changes Apr 20, 2017
View reviewed changes
Copy link
Member

@egonw egonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the possible typo. Otherwise looks good.

tool/sdg/src/main/java/org/openscience/cdk/layout/NonplanarBonds.java Outdated
return labels.length == 4 && counrRingBonds(bonds) != 3;
}

private int counrRingBonds(IBond[] bonds) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep will fix

@egonw egonw merged commit c05eac4 into master Apr 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egonw egonw egonw requested changes

Assignees

@johnmay johnmay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnmay @egonw