Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox-bin: 52.0.2 -> 53.0, firefox-esr: 52.0.2esr -> 52.1.0esr [Critical security fixes] #25043

Merged
merged 2 commits into from Apr 22, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Apr 19, 2017

Motivation for this change
  • Critical security fixes
  • Two new 'compact' themes available in Firefox, dark and light, based on the Firefox Developer Edition theme
  • Lightweight themes are now applied in private browsing windows
  • Reader Mode now displays estimated reading time for the page
  • Updated the design of site permission requests to make them harder to miss and easier to understand
  • New visual design for audio and video controls
  • Ended Firefox Linux support for processors older than Pentium 4 and AMD Opteron
  • Support for WebM video with alpha, which allows playing videos with transparent backgrounds

https://www.mozilla.org/en-US/firefox/53.0/releasenotes/
https://www.mozilla.org/en-US/firefox/52.1.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2017-10/

Tested (playing a YouTube video) both firefox-bin and firefox-esr. firefox-esr may not work with old profiles made with older firefox-bin, but it works with a fresh profile.

I could not build firefox (source package) yet. It now requires Rust and Cargo, but adding cargo and rustc (or rust) to nativeBuildInputs does not work.
[edit] I edited a wrong file. Now configure succeeds and compiling. [/edit]
[edit] I got /tmp/nix-build-firefox-unwrapped-53.0.drv-0/firefox-53.0/extensions/spellcheck/hunspell/glue/mozHunspell.cpp:203:34: error: 'class Hunspell' has no member named 'get_dict_encoding'. Maybe hunspell need to be updated. [/edit]

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@taku0, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @abbradar and @vcunat to be potential reviewers.

@taku0
Copy link
Contributor Author

taku0 commented Apr 19, 2017

I got error /tmp/nix-build-firefox-unwrapped-53.0.drv-0/firefox-53.0/extensions/spellcheck/hunspell/glue/mozHunspell.cpp:203:34: error: 'class Hunspell' has no member named 'get_dict_encoding' while building firefox. Maybe hunspell need to be updated.

I cannot investigate it deeper until tomorrow or later. Please merge firefox-bin and firefox-esr first.

vdemeester pushed a commit to vdemeester/nixpkgs that referenced this pull request Apr 22, 2017
@vcunat vcunat merged commit acf1254 into NixOS:master Apr 22, 2017
vcunat added a commit that referenced this pull request Apr 22, 2017
@vcunat
Copy link
Member

vcunat commented Apr 22, 2017

Picked to 17.03, too, after a bit of testing. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants