Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable parallel building #25032

Merged
merged 1 commit into from Apr 19, 2017
Merged

Disable parallel building #25032

merged 1 commit into from Apr 19, 2017

Conversation

dmjio
Copy link
Member

@dmjio dmjio commented Apr 19, 2017

Motivation for this change

Race condition with make -j is causing the build to fail. This should fix it.
cc @cleverca22 @Ericson2314

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 merged commit 124c4b1 into NixOS:master Apr 19, 2017
@dmjio dmjio deleted the patch-1 branch April 19, 2017 21:19
@Mic92
Copy link
Member

Mic92 commented Apr 20, 2017

next time it would be nice to also prefix the package in the commit message, which was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants