Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskell generic builder: Use ghcjs's hsc2hs. #24663

Merged
merged 1 commit into from Apr 6, 2017
Merged

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Apr 6, 2017

This is required when using ghcjs to compile Setup.hs, which we do since #23614.

See comments on ghcjs/ghcjs@c35350a

@shlevy shlevy requested a review from peti April 6, 2017 01:10
@mention-bot
Copy link

@shlevy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peti, @cstrahan and @expipiplus1 to be potential reviewers.

@shlevy
Copy link
Member Author

shlevy commented Apr 6, 2017

@peti @ljli I'd rather revert #23614 , but this is needed if not (tests still running locally)

This is required when using ghcjs to compile Setup.hs, which we do since #23614.

See comments on ghcjs/ghcjs@c35350a
@peti peti merged commit e105ba6 into master Apr 6, 2017
@peti peti deleted the ghcjs-no-native-hsc2hs branch April 6, 2017 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants