nitrokey-app: 0.5.1 -> 0.6.3 #24219
nitrokey-app: 0.5.1 -> 0.6.3 #24219
Conversation
|
|
||
| src = fetchFromGitHub { | ||
| owner = "Nitrokey"; | ||
| repo = "nitrokey-app"; | ||
| rev = "v${version}"; | ||
| sha256 = "0acb2502r3wa0mry6h8sz1k16zaa4bgnhxwxqd1vd1y42xc6g9bw"; | ||
| sha256 = "1l5l4lwxmyd3jrafw19g12sfc42nd43sv7h7i4krqxnkk6gfx11q"; | ||
| }; | ||
|
|
||
| buildInputs = [ |
There was a problem hiding this comment.
cmake, pkgconfig should be in nativeBuildInputs
There was a problem hiding this comment.
Remove stdenv.lib from license and maintainer and add it to meta like meta = with stdenv.lib; {
instead of writing it multiple times.
There was a problem hiding this comment.
Also, just curious, wouldn't it be some what simpler instead of using a patch to use substituteInPlace since there isn't that many changes?
There was a problem hiding this comment.
I fixed the issues you mentioned, thanks for pointing out.
I keep the patches for now. But I will keep in mind your recommendation and will reexamine my decision when updating to the next upstream version.
|
Is there anything that prevents this change from being merged? @ndowens |
Motivation for this change
Update to latest upstream version.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)