Thunderbird: Fix default mail client detection #24961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The refactoring in b023370 ported changes from firefox-unwrpped, but dropped features in firefox's wrapper. Add the desktop item and remove useless dev files.
layus
force-pushed
the
thunderbird-default-mail-client
branch
from
89bcc49
to
c11c9ff
Compare
|
Ooops, found a bug in the meantime. it would be simpler to enforce gtk3 to get only one build to test. |
layus
changed the title
layus
force-pushed
the
thunderbird-default-mail-client
branch
from
c11c9ff
to
ac34cc1
Compare
|
Voilà, I got it working properly. This is difficult because we need to use wrapGAppsHook when gtk3 is enabled, and makeWrapper otherwise... @abbradar Would you mind reviewing this ? |
layus
changed the title
layus
force-pushed
the
thunderbird-default-mail-client
branch
from
ac34cc1
to
eb8f604
Compare
abbradar
reviewed
Apr 17, 2017
|
It is hacky because
|
|
Tested; it works for me. Thanks for this and for restoring features which I accidentially removed! |
|
Thanks for reviewing :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fix regression from b023370, and default mail reader detection (see also #23516)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)/cc @abbradar