Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elm-format: symlink latest version to bin/elm-format #24971

Merged
merged 2 commits into from Apr 17, 2017

Conversation

nicknovitski
Copy link
Contributor

As it stands, the package installs bin/elm-format-0.18, 0.17, and 0.16. But I noticed that elm-vim expects a binary that's just called elm-format, and that all of elm-format's install instructions give you a single binary just called elm-format.

This seemed to be the simplest change to match community expectations.

@mention-bot
Copy link

@nicknovitski, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Adjective-Object and @garbas to be potential reviewers.

@Mic92 Mic92 merged commit b47e022 into NixOS:master Apr 17, 2017
@kuznero
Copy link
Member

kuznero commented Jun 1, 2017

For some reason after installing elmPackages.elm-format (0.5.2) I still don't have elm-format symlink to elm-format-0.18. What can be wrong? Perhaps, the change still didn't make it to official channel? Then perhaps version 0.5.2 should have been increased?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants