rocker: init at 1.3.0 #24966
Closed
rocker: init at 1.3.0 #24966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NeQuissimus
force-pushed
the
rocker_1_3_0
branch
from
a953c57
to
0171e66
Compare
Mic92
reviewed
Apr 17, 2017
| src = fetchurl { | ||
| url = "https://github.com/grammarly/rocker/releases/download/${version}/rocker_linux_amd64.tar.gz"; | ||
| sha256 = "0jcxphkarzicxif2virdr7d7kym0961ca5l59cxmaqxa46l6k5x0"; | ||
| }; |
There was a problem hiding this comment.
What was the reason for not using go2nix to build a go package from source?
Mic92
reviewed
Apr 17, 2017
| mkdir -p {$bin,$out} | ||
| mv rocker $bin/rocker | ||
| chmod +x $bin/rocker | ||
| ln -s $bin $out/bin |
There was a problem hiding this comment.
What is the purpose of this extra bin output?
|
I will make some changes, this was the quickest way for me to get to using the tool locally :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add the tool to nixpkgs. I need to do some fancy things with Docker :)
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)