Refactor command-not-found #24962
Refactor command-not-found #24962
Conversation
makefu
force-pushed
the
modules/command-not-found/refactor
branch
from
43f1b7f
to
77d8cc0
Compare
| options.programs.command-not-found = { | ||
|
|
||
| enable = mkOption { | ||
| default = true; |
There was a problem hiding this comment.
I would even argue to disable this at the moment, because the sqlite database is almost empty since 16.09:
16.03:
$ sqlite3 /nix/var/nix/profiles/per-user/joerg/channels/nixos/programs.sqlite "select count(*) from Programs;"
23209
16.09:
$ sqlite3 /nix/var/nix/profiles/per-user/joerg/channels/nixos/programs.sqlite "select count(*) from Programs;"
653
17.03:
$ sqlite3 /nix/var/nix/profiles/per-user/joerg/channels/nixos/programs.sqlite "select count(*) from Programs;"
343
|
@Mic92 i wanted to preserve the original behavior but you are right, with the current state it would be best to disable them by default. |
add option to disable command-not-found as well as option to define dbPath. Disabling this may remove the perl dependency for bash/zsh prompts
makefu
force-pushed
the
modules/command-not-found/refactor
branch
from
77d8cc0
to
5a5db60
Compare
|
Anybody who want to fix |
|
@edolstra did some work with nar listing files recently. I also had a separate proposal for fixing it inside nixpkgs, but we decided to follow the nar listing files instead. If that isn't working properly, we might consider reviving my other proposal, which I think is easier to maintain without special support from Nix/Hydra or assumptions about binary caches. |
|
@copumpkin This PR only provides a way to enable and disable I'd really like to see my PR being merged to avoid having to maintain a fork of nixpkgs with this commit cherry-picked on top for the rest of eternity ;) |
Motivation for this change
as of right now command-not-found is not working because programs.sqlite is not populated inside the channels. I took this as a chance to customize the current command-not-found module.
With
programs.command-not-found.enablethe feature can be disabled if unneeded.With
programs.command-not-found.dbPaththe path to the db can be specified explicitly in case no channels are in use.Things done
./result/bin/)