abbreviate_artistsort: Get rid of print statements #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Picards logging module is already imported, there's no need to reinvent debug levels etc. here
…message Without this, the plugin doesn't work.
|
I have no idea why I used print rather than log when I wrote this!!! But don't forget to increment the version number. |
zas
approved these changes
Apr 19, 2017
|
Those changes should be ported to 2.0 version too |
Freso
reviewed
Apr 19, 2017
| print() | ||
| log.warning() | ||
| log.warning("Error: Unsorted text for %s has changed from '%s' to '%s'!" % (unsortTag, unsorts[i], new_unsort)) | ||
| log.warning() |
There was a problem hiding this comment.
These empty log.warning()s are probably unneeded now, no?
There was a problem hiding this comment.
These empty log.warning()s are probably unneeded now, no?
Yes, i missed those, totally unneeded ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picards logging module is already imported, there's no need to reinvent debug
levels etc. here
I've loaded a classical album with this plugin active, the plugin showed some warnings, but the release loaded, so I suppose everything still works.