nfdump: init at 1.6.15 #24490
Merged
nfdump: init at 1.6.15 #24490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndowens
suggested changes
Mar 30, 2017
| ''; | ||
| homepage = https://github.com/phaag/nfdump; | ||
| license = with licenses; bsd3; | ||
| maintainers = with maintainers; [ takikawa ]; |
There was a problem hiding this comment.
Since it is one person, and one maintainer, don't use with ....; []
There was a problem hiding this comment.
Thanks, I think I've addressed that now (and for platforms).
ndowens
suggested changes
Mar 31, 2017
|
I guess you can squash these changes down to one commit. |
|
Sorry for the lack of response on this, I squashed the commits and pushed it to my branch just now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This PR adds the nfdump (old sourceforge page is here) tool for working with netflow/IPFIX data for networking.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)