Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document SpongeGradle Ore Deploy plugin #589

Closed
wants to merge 5 commits into from
Closed

Document SpongeGradle Ore Deploy plugin #589

wants to merge 5 commits into from

Conversation

windy1
Copy link
Contributor

@windy1 windy1 commented Mar 31, 2017

Signed-off-by: Walker Crouse walkercrouse@hotmail.com

@windy1 windy1 added input wanted We would like to hear your opinion needs review The submission is ready and needs to be reviewed on hold Progress is blocked for some reason labels Mar 31, 2017
@Spongy
Copy link

Spongy commented Apr 3, 2017

A preview for this pull request is available at https://cdn.rawgit.com/Spongy/SpongeDocs-PRs/f09fdf1/.

Here are some links to the pages that were modified:

Since the preview frequently changes, please link to this comment, not to the direct url to the preview.

@ST-DDT
Copy link
Member

ST-DDT commented Sep 21, 2017

@windy1 Mind fixing the issue @Minecrell pointed out? What else needs to be done to get this PR ready?

@Asherslab
Copy link

Just BTW from experience with using this spongeGradle plugin, you may want to add that people must add the

buildscript {
    dependencies {
        classpath 'org.apache.httpcomponents:httpmime:4.5.3'
    }
}

to their build.gradle 😄

@Inscrutable Inscrutable removed the on hold Progress is blocked for some reason label Jan 14, 2018
@progwml6
Copy link
Member

@dualspiral has been testing this pr

@ST-DDT
Copy link
Member

ST-DDT commented Apr 15, 2018

How is the status of this PR?

@Inscrutable Inscrutable added the Ore Related to Ore label Apr 20, 2018
@ST-DDT
Copy link
Member

ST-DDT commented Jul 11, 2018

@windy1 Do you mind if I update and finish the PR? You might have to check the "allow contributors to update" button. Otherwise I have to create a new PR with these changes.

windy1 and others added 2 commits July 12, 2018 19:14
@ST-DDT ST-DDT self-assigned this Jul 12, 2018
@ST-DDT
Copy link
Member

ST-DDT commented Jul 12, 2018

@Asherslab

Just BTW from experience with using this spongeGradle plugin, you may want to add that people must add the

buildscript {
   dependencies {
       classpath 'org.apache.httpcomponents:httpmime:4.5.3'
   }
}

to their build.gradle 😄

Is this still necessary? Is there a stacktrace or something that I could mention with this as a fix? Is it possible to update to 4.5.6?

@Asherslab
Copy link

@ST-DDT i do not have a stacktrace for it sorry, and it may not be necessary anymore, it was at the time

@Inscrutable Inscrutable requested a review from mbax July 14, 2018 01:12
oreDeloy.apiKey=8c115d0c9b9e425281d870e329dd6741

As an alternative you can supply them via command line parameters like this
``-PoreDeloy.apiKey=8c115d0c9b9e425281d870e329dd6741``.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deploy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@ST-DDT
Copy link
Member

ST-DDT commented Jul 16, 2018

Ready for final review and merge.

@Inscrutable Inscrutable requested a review from mbax July 19, 2018 09:54
@Inscrutable Inscrutable removed the input wanted We would like to hear your opinion label Jul 19, 2018
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^^

@Inscrutable
Copy link
Member

Would you care to give this a PR green light @mbax ?

@mbax
Copy link
Contributor

mbax commented Jul 28, 2018

@Inscrutable My understanding was that the instructions had not yet been confirmed to work, just cleaned up from the original PR.

I have not yet had the time to test it, and sadly nobody else responded when I asked in public channels for help.

@Inscrutable Inscrutable added the on hold Progress is blocked for some reason label Jul 29, 2018
@Inscrutable Inscrutable added the help wanted We would appreciate contributions label Sep 7, 2018
@BrainStone
Copy link

Ok. I just tested this.

A few things I noticed:

  • It's missing that you need to add the OreDeploy-Plugin itself (the Sponge plugin is not enough)
  • I'm also missing how to add the changelog.

But other than that it's working!

@ST-DDT
Copy link
Member

ST-DDT commented Sep 23, 2018

Could you add a snippet with the missing plugin configuration and the changelog generation? Or link to your plugin where you have configured this.

@BrainStone
Copy link

How to apply the plugin is detailed here: https://plugins.gradle.org/plugin/org.spongepowered.ore

And I might have expressed myself poorly, but I don’t know how to set the changelog either. I’d love to know how it’s done.

@phit
Copy link
Contributor

phit commented Sep 24, 2018

@Katrix you added the changelog stuff, mind explaining how to set it up?

@BrainStone
Copy link

I'm also missing how to select a jar from a different task than jar. Like I need the artifact of the task shadowJar uploaded instead of the artifact from jar.

@Inscrutable Inscrutable removed the on hold Progress is blocked for some reason label Nov 18, 2018
@Katrix
Copy link
Member

Katrix commented Nov 29, 2018

Sorry for taking so long with answering. I forgot about this thing. For changelog and forum post, add forumPost and changelog values in the ore block, the same way as you set if it's recommended or the channel to publish to.

As for selecting a different jar. No idea. Not sure if it's possible. The task looks at the artifacts in the build, but not a Gradle expert, so can't tell you more.

@Inscrutable
Copy link
Member

The layers of dust on this PR are forming into sedimentary stone. How much do we need to test and/or fix before it can go live, @Katrix @mbax et al?

@Katrix
Copy link
Member

Katrix commented Jan 19, 2019

It's those two extra values I mentioned above. Then someone (preferably someone with experience) need to just make sure that everything works. Personally, I can't say for sure if it's correct or not, as I've only ever used my own SBT implementation.

Unsure if groovy supports triple quotes so not used.
@Inscrutable Inscrutable removed the help wanted We would appreciate contributions label Jan 24, 2019
@ST-DDT ST-DDT removed their assignment May 18, 2019
@ST-DDT
Copy link
Member

ST-DDT commented May 18, 2019

Closing in favor of #799

@ST-DDT ST-DDT closed this May 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review The submission is ready and needs to be reviewed Ore Related to Ore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet