New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document SpongeGradle Ore Deploy plugin #589
Conversation
A preview for this pull request is available at https://cdn.rawgit.com/Spongy/SpongeDocs-PRs/f09fdf1/. Here are some links to the pages that were modified:
Since the preview frequently changes, please link to this comment, not to the direct url to the preview. |
@windy1 Mind fixing the issue @Minecrell pointed out? What else needs to be done to get this PR ready? |
Just BTW from experience with using this spongeGradle plugin, you may want to add that people must add the
to their build.gradle 😄 |
@dualspiral has been testing this pr |
How is the status of this PR? |
@windy1 Do you mind if I update and finish the PR? You might have to check the "allow contributors to update" button. Otherwise I have to create a new PR with these changes. |
Signed-off-by: Walker Crouse <walkercrouse@hotmail.com>
Is this still necessary? Is there a stacktrace or something that I could mention with this as a fix? Is it possible to update to |
@ST-DDT i do not have a stacktrace for it sorry, and it may not be necessary anymore, it was at the time |
source/ore/gradle-deploy.rst
Outdated
oreDeloy.apiKey=8c115d0c9b9e425281d870e329dd6741 | ||
|
||
As an alternative you can supply them via command line parameters like this | ||
``-PoreDeloy.apiKey=8c115d0c9b9e425281d870e329dd6741``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deploy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Ready for final review and merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^
Would you care to give this a PR green light @mbax ? |
@Inscrutable My understanding was that the instructions had not yet been confirmed to work, just cleaned up from the original PR. I have not yet had the time to test it, and sadly nobody else responded when I asked in public channels for help. |
Ok. I just tested this. A few things I noticed:
But other than that it's working! |
Could you add a snippet with the missing plugin configuration and the changelog generation? Or link to your plugin where you have configured this. |
How to apply the plugin is detailed here: https://plugins.gradle.org/plugin/org.spongepowered.ore And I might have expressed myself poorly, but I don’t know how to set the changelog either. I’d love to know how it’s done. |
@Katrix you added the changelog stuff, mind explaining how to set it up? |
I'm also missing how to select a jar from a different task than |
Sorry for taking so long with answering. I forgot about this thing. For changelog and forum post, add As for selecting a different jar. No idea. Not sure if it's possible. The task looks at the artifacts in the build, but not a Gradle expert, so can't tell you more. |
It's those two extra values I mentioned above. Then someone (preferably someone with experience) need to just make sure that everything works. Personally, I can't say for sure if it's correct or not, as I've only ever used my own SBT implementation. |
Unsure if groovy supports triple quotes so not used.
Closing in favor of #799 |
Signed-off-by: Walker Crouse walkercrouse@hotmail.com