@peterhoeg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joachifm, @edolstra and @vcunat to be potential reviewers.

ping @abbradar

Indeed @abbradar , thanks and fixed.

systemd is a mass-rebuild due utillinux, right?

I'm not sure if it is due to utillinux, but it's definitely mass-rebuild.

Assuming everybody is OK with this change, maybe we should introduce a "mass-rebuild-ready-to-merge" label for stuff that's not urgent.

• Adding bashInteractive increases systemd's closure size, which is undesirable given the number of packages that depend (indirectly) on systemd.

• I'm not sure it's very useful to enable an untested feature. Also, wouldn't TPM require support from lots of other parts in the stack? (E.g. boot loader, kernel, etc.) So just enabling it in systemd won't do very much.

Since this PR is for the staging branch, it's not a problem if it causes lots of rebuilds btw.

bashInteractive will only be a dependency of systemd.out, not systemd.lib, which should be okay for most packages (I don't think there are many situations when one has systemd.out but not bashInteractive -- most likely he/she is on NixOS).

I don't have an opinion on TPM however -- it's indeed an untested feature. Maybe we can save ourselves one mass rebuild in the future when one puts some work to it, but maybe it breaks something...

Any progress?

None from here, no.

Are there any updates on this pull request, please?

If would be great if somebody with TPM hardware could test this out.

@peterhoeg I would drop the TPM support for now until somebody tested it.

I'd argue that adding TPM doesn't break anything as we are not changing existing behaviour or removing functionality, so why not just get it in there and see if it works for whoever has the hardware?

If we don't know it works, there's not much value in adding a untested and potentially broken feature.

@peterhoeg it is not so useful without further integration and if nobody cares enough to add this support then why should we bloat systemd more than necessary.

Let's cherry-pick debug shell patch and leave TPM patch for now. I'd like to play with it (my laptop has a TPM) later.

@abbradar was the debug shell patch moved into a separate PR already?

@flokli Nope, sorry, forgot about it. I built a VM with it and it appears to work so I'll cherry-pick it to staging-next.

EDIT: Done.

Thanks. As the TPM patch is really trivial (-Dtpm=true), let's close this PR for now.