Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpgme: 1.8.0 -> 1.9.0 #24491

Closed
wants to merge 0 commits into from
Closed

gpgme: 1.8.0 -> 1.9.0 #24491

wants to merge 0 commits into from

Conversation

primeos
Copy link
Member

@primeos primeos commented Mar 30, 2017

Motivation for this change

Note: This drops support for gnupg1orig via useGnupg1, due to the following reasons:

  • No other package in this repo depends on this
  • gpgProgram wasn't actually used
  • gnupg was used instead of gpgStorePath as build input
  • The name gnupg1 was misleading because it was actually gnupg1orig
  • Using gnupg1orig should still be possible by simply overwriting gnupg.

@Fuuzetsu I added myself as a maintainer since I assume you don't have much time for this atm (correct me if I'm wrong 馃槃).

nix-shell -p nox --run "nox-review wip" is currently failing for kde4.pykde4 but that package was actually failing before. Can we actually remove that package btw? I'm not that familiar with KDE and the KDE 4 removal (just noticed the announcement on nix-dev).

Noteworthy changes in version 1.9.0

From the mailinglist:

  • Clarified meaning of the 'expire' parameter of gpgme_op_createkey
    and gpgme_op_createsubkey. New flag to force a key without an
    expiration date.

  • New function gpgme_op_keylist_from_data_start to list keys from
    data objects without importing them.

  • New function gpgme_op_set_uid_flag to flag a key as primary.

  • New function gpgme_op_decrypt_ext to run decryption with special
    flags. This can for example be used to unwrap keys (remove only
    the encryption layer).

  • New encryption flags to wrap a key (adding an encryption layer to
    an OpenPGP message) or to create anonymously encrypted messages.

  • Support for adduid and revuid operations in the C++ bindings.

  • Support for smartcard key generation in the C++ bindings.

  • Several new functions for the Python binding.

  • Many smaller bug fixes.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip" (except calligra (took very long...))
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@primeos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @aszlig and @fpletz to be potential reviewers.

];

NIX_CFLAGS_COMPILE =
with stdenv; lib.optional (system == "i686-linux") "-D_FILE_OFFSET_BITS=64";

AM_CXXFLAGS =
with stdenv; lib.optional (isDarwin) "-D_POSIX_C_SOURCE=200809L";

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be fixed in 1.9.0: https://bugs.gnupg.org/gnupg/issue2910

Thanks @orivej for noticing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants