i3lock-color: 2.7-2016-09-17 -> 2.7-2017-04-01; Closes #24450 #24493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ndowens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @garbas, @yorickvP and @domenkozar to be potential reviewers. |
NeQuissimus
requested changes
Mar 31, 2017
| name = "i3lock-color-${version}"; | ||
| src = fetchFromGitHub { |
There was a problem hiding this comment.
Does this not turn this whole thing into a different piece of software?
Now you pull i3lock without the colour extensions from i3lock-color.
|
Crap didn't think about that will fix tomorrow
…Sent from my iphone
On Mar 30, 2017, 9:10 PM -0500, Tim Steinbach ***@***.***>, wrote:
@NeQuissimus requested changes on this pull request.
In pkgs/applications/window-managers/i3/lock-color.nix (#24493 (comment)):
> name = "i3lock-color-${version}"; - src = fetchFromGitHub {
Does this not turn this whole thing into a different piece of software?
Now you pull i3lock without the colour extensions from i3lock-color.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#24493 (review)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL7yCvQIVB79TkFa2arLDM1mjMLJ8vks5rrGB8gaJpZM4MvCOs).
|
|
@NeQuissimus done |
|
AFAICT, there's no 2.8 release of i3lock-color. Better name it 2.7-2017-04-01 I suppose. Does it still compile with the updated deps? |
|
It compiled just forgot to change version
…Sent from my iphone
On Apr 1, 2017, 7:36 AM -0500, Yorick ***@***.***>, wrote:
AFAICT, there's no 2.8 release of i3lock-color. Better name it 2.7-2017-04-01 I suppose. Does it still compile with the updated deps?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub (#24493 (comment)), or mute the thread (https://github.com/notifications/unsubscribe-auth/AAHL7yu7tvTIWHM5E4HuYDPIY27TA1Ciks5rrkMygaJpZM4MvCOs).
|
i3lock-color: Corrected software src Fixed version
ndowens
changed the title
|
@NeQuissimus Fixed version; Sorry been half sleep lately from work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update Closes: #24450
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)