LB-146: Fix fetch of listens from listenstore in user export #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayhem
requested changes
Mar 31, 2017
The call to db_conn.fetch_listens was not correct as it didn't have from_ts or to_ts. To get all listens, add a loop that makes repeated queries to the listenstore until there are no more listens left to get.
paramsingh
force-pushed
the
views/user-export
branch
from
eedee82
to
c164496
Compare
|
Test added :) |
paramsingh
force-pushed
the
views/user-export
branch
2 times, most recently
from
04133be
to
7b308fb
Compare
paramsingh
force-pushed
the
views/user-export
branch
from
7b308fb
to
6200305
Compare
mayhem
reviewed
Apr 3, 2017
There was a problem hiding this comment.
I'm getting a test fail on the new test now:
# now export data and check if contains all the listens we just sent
resp = self.client.post(url_for('user.export_data'))
self.assert200(resp)
data = json.loads(resp.data)
self.assertEquals(len(data), 2)
E AssertionError: 5 != 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to db_conn.fetch_listens was not correct as it didn't have
from_ts or to_ts. To get all listens, add a loop that makes
repeated queries to the listenstore until there are no more listens
left to get.