Skip to content

Commit

Permalink
display-manager: fix argument handling of sddm
Browse files Browse the repository at this point in the history
previously session type was not correctly set.

fixes #23264
  • Loading branch information
Mic92 committed Apr 17, 2017
1 parent 81e6e21 commit 6b7c5ba
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions nixos/modules/services/x11/display-managers/default.nix
Expand Up @@ -32,8 +32,14 @@ let
''
#! ${pkgs.bash}/bin/bash
# Handle being called by SDDM.
if test "''${1:0:1}" = / ; then eval exec $1 $2 ; fi
# SDDM splits "Exec" line in .desktop file by whitespace and pass script path as $1
if [[ "$0" = "$1" ]]; then
# remove superfluous $1 again
shift
# join arguments again and evaluate them in a shell context
# to interpret shell quoting
eval exec "$0" "$@"
fi
${optionalString cfg.displayManager.logToJournal ''
if [ -z "$_DID_SYSTEMD_CAT" ]; then
Expand Down

2 comments on commit 6b7c5ba

@cleverca22
Copy link
Contributor

@cleverca22 cleverca22 commented on 6b7c5ba Apr 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this appears to also break slim and lightdm

@primeos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cleverca22 It's now reverted on 17.03 and master - Looking at the old comment I thought this wouldn't affect other display managers but apparently all DMs are calling the xsessions script like this now... :o

Please sign in to comment.