Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc for Platform Normalization #24980

Merged
merged 1 commit into from Apr 18, 2017

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Apr 18, 2017

Motivation for this change

Oops forgot to add to previous PR. If anyone proofreads--thanks!

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@Ericson2314, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @rbvermaa and @aszlig to be potential reviewers.

@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Apr 18, 2017
@Ericson2314 Ericson2314 changed the title Doc and release-cross fix for Platform normalization Doc for Platform Normalization Apr 18, 2017
@Ericson2314
Copy link
Member Author

What's this error, the nixos manual? Everything builds locally for me.

@Ericson2314
Copy link
Member Author

Ah good catch. That's not right.

Worthwhile to do now that NixOS#24610 makes it less abysmal.
@Ericson2314 Ericson2314 merged commit 1eabc23 into NixOS:master Apr 18, 2017
@Ericson2314 Ericson2314 deleted the platform-normalization branch April 18, 2017 17:35
@Ericson2314 Ericson2314 added this to Prior in Cross compilation Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants