Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grub module: efiInstallAsRemovable description wrap <para> in <note> #24987

Closed
wants to merge 1 commit into from
Closed

grub module: efiInstallAsRemovable description wrap <para> in <note> #24987

wants to merge 1 commit into from

Conversation

zraexy
Copy link
Member

@zraexy zraexy commented Apr 18, 2017

Motivation for this change

Removed first <para> and wrapped others in <note> to avoid build failure introduced by: #24978

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@zraexy, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @wkennington and @obadz to be potential reviewers.

@vcunat vcunat closed this Apr 18, 2017
@zraexy
Copy link
Member Author

zraexy commented Apr 18, 2017

@vcunat Reverting #24978 still leaves the original issue. Should I make a new pull request for wrapping it in <note>?

@vcunat
Copy link
Member

vcunat commented Apr 18, 2017 •
edited

I don't think any original issue exists. I guess the comments are always wrapped by <para> </para> pairs. In any case, we do validate the resulting XML, as that's what got broken.

@vcunat
Copy link
Member

vcunat commented Apr 18, 2017

In any case it's confusing and the situation might be worth investigating and perhaps documenting (though people probably wouldn't get to read that bit).

@zraexy
Copy link
Member Author

zraexy commented Apr 18, 2017

Looking at it some more, I think the issue is with the website. Before the xml is parsed it gets wrapped in a <div> instead of a <para> so during parsing the <div> gets ignored and it tries to close a non existent <para>.

@vcunat
Copy link
Member

vcunat commented Apr 18, 2017

Indeed, http://nixos.org/nixos/manual/options.html doesn't validate.

@zraexy zraexy deleted the zraexy-grub branch April 25, 2017 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zraexy @mention-bot @vcunat