New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded MinGW-W64 to stable version 5.0.3 #24985
Conversation
Yes, Thanks for the tip about MSYS2, a project that relies heavily on mingw-w64, usually just builds from the latest Git version, and I find that to be convenient too because mingw-w64 can take a long time between releases and most of the commits to it are pretty straightforward bug fixes. The upstream project is also pretty fast at accepting patches when I send them. So I would prefer to use git, but I suppose it also works to do it this way and just patch it as needed in nixpkgs. |
I'm fine with using the latest git revision, but I've usually found there to be a fairly strong bias in nixpkgs towards using the latest stable release (and having |
It would also acceptable to have a newer |
I think having both stable and unstable is OK when there is a reason to have unstable, too. Maybe adding meta would be a good idea. |
This would break 32-bit builds, as
You can test quickly e.g. by |
ad4a06e
to
e75f269
Compare
@taktoa I last summer split that derivation up kind of like you did, but into separate files. I figured that was good enough, but integrated your extra configure flags, and then cherry-picked @angerman's patch. I'll get hydra to build this to see what happens! https://hydra.nixos.org/eval/1436486 |
e75f269
to
882ce39
Compare
This came up with GHC, as GHC requires `_(un)lock_file`, which are only present in mingw-w64 >= 5.
882ce39
to
1d3db81
Compare
Ooop, I had broken the cross jobs quite bad. https://hydra.nixos.org/eval/1442341 has it. |
OK hydra is slow but I built in manually. Thanks, you both! |
Motivation for this change
There is a new version of MinGW-W64, so I updated the package to use that.
I also refactored the package a bit and added the
--enable-idl
and--enable-secure-api
flags which I found necessary when hacking on MinGW cross compilation last October.
I tested all the packages in
crossMingwW64
and they all compile except forcoreutils
,guile_1_8
(becauselibsigsegv
fails), andwindows.wxMSW
. See #24984 for more details. Note that all three of those packages were broken before this change.Things done
build-use-sandbox
innix.conf
)nix-shell -p nox --run "nox-review wip"
./result/bin/
)