Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2690 — make date ranges work in shortcode post lists #2711

Merged
merged 1 commit into from Apr 6, 2017

Conversation

Kwpolska
Copy link
Member

@Kwpolska Kwpolska commented Apr 6, 2017

I implemented this as a special case in shortcodes as opposed to making
global changes, because other shortcodes may break, and I’d say that
more shortcodes would want escapes and processing done for them.

cc @felixfontein, @ralsina, @gkabbe

I implemented this as a special case in shortcodes as opposed to making
global changes, because other shortcodes may break, and I’d say that
more shortcodes would want escapes and processing done for them.

Signed-off-by: Chris Warrick <kwpolska@gmail.com>
@Kwpolska Kwpolska added this to the v7.8.5 milestone Apr 6, 2017
Copy link
Contributor

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Surely not the most elegant/generic solution (such would have their own problems, as you mentionied in #2690), but a good enough hack for this problem.

@Kwpolska Kwpolska merged commit cb5874e into master Apr 6, 2017
@Kwpolska Kwpolska deleted the fix-2690 branch April 6, 2017 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants