Make ssl sockets buffered. Fixes #4248

crystal-lang · Apr 6, 2017 · 32e4dd5 · Sija · Apr 6, 2017 · 32e4dd5
1 parent eae4193
commit 32e4dd5
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/src/openssl/ssl/socket.cr b/src/openssl/ssl/socket.cr
@@ -68,7 +68,7 @@ abstract class OpenSSL::SSL::Socket
     end
   end
 
-  include IO
+  include IO::Buffered
 
   # If `#sync_close?` is `true`, closing this socket will
   # close the underlying IO.
@@ -91,7 +91,7 @@ abstract class OpenSSL::SSL::Socket
     LibSSL.ssl_free(@ssl)
   end
 
-  def read(slice : Bytes)
+  def unbuffered_read(slice : Bytes)
     check_open
 
     count = slice.size
@@ -104,7 +104,7 @@ abstract class OpenSSL::SSL::Socket
     end
   end
 
-  def write(slice : Bytes)
+  def unbuffered_write(slice : Bytes)
     check_open
 
     count = slice.size
@@ -115,7 +115,7 @@ abstract class OpenSSL::SSL::Socket
     nil
   end
 
-  def flush
+  def unbuffered_flush
     @bio.io.flush
   end
 
@@ -128,7 +128,7 @@ abstract class OpenSSL::SSL::Socket
   end
   {% end %}
 
-  def close
+  def unbuffered_close
     return if @closed
     @closed = true
 
@@ -165,4 +165,8 @@ abstract class OpenSSL::SSL::Socket
       @bio.io.close if @sync_close
     end
   end
+
+  def unbuffered_rewind
+    raise IO::Error.new("can't rewind OpenSSL::SSL::Socket::Client")
+  end
 end