2bwm: init at 0.2 #24410
Merged
2bwm: init at 0.2 #24410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sternenseemann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nbp, @AndersonTorres and @edolstra to be potential reviewers. |
ndowens
suggested changes
Mar 28, 2017
|
|
||
| installPhase = "make install DESTDIR=$out PREFIX=\"\""; | ||
|
|
||
| meta = with stdenv.lib; { |
There was a problem hiding this comment.
No need of using stdenv.lib in fields below meta since you did meta = with stdenv.lib; {
| homepage = "https://github.com/venam/2bwm"; | ||
| description = "A fast floating WM written over the XCB library and derived from mcwm"; | ||
| license = stdenv.lib.licenses.mit; | ||
| maintainers = with maintainers; [ sternenseemann ]; |
There was a problem hiding this comment.
maintainers = [ maintainers.sternenseemann ];
| @@ -0,0 +1,29 @@ | |||
| { stdenv, fetchFromGitHub, patches | |||
| , libxcb, xcbutilkeysyms, xcbutilwm, libX11, xcbutil, xcbutilxrm }: | |||
There was a problem hiding this comment.
For "nice-looking" move the line , libX11, .... to next line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
./result/bin/)