Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox bin 52.0.2 #24407

Merged
merged 3 commits into from Mar 28, 2017
Merged

Firefox bin 52.0.2 #24407

merged 3 commits into from Mar 28, 2017

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Mar 28, 2017

Motivation for this change
  • Bug fixes

https://www.mozilla.org/en-US/firefox/52.0.2/releasenotes/

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@taku0, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @vcunat and @bluescreen303 to be potential reviewers.

@globin
Copy link
Member

globin commented Mar 28, 2017

Does that fix the e10s bug? #24295

@7c6f434c 7c6f434c merged commit 8c28474 into NixOS:master Mar 28, 2017
@7c6f434c
Copy link
Member

@globin Let's experiment…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants