treewide: use boolToString function #24830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpletz
force-pushed
the
refactor/boolToString
branch
from
8abd39d
to
3ab45f4
Compare
Mic92
approved these changes
Apr 13, 2017
globin
approved these changes
Apr 13, 2017
|
Okay with three approvals I'm just going to merge 😄 |
|
I really wonder how you managed to create |
|
Ah, sorry, I've been messing with https://www.irif.fr/~jch/software/babel/ a lot lately. 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Lots of modules define a function to convert bools to
"true"or"false", so there should be a function in the library for doing exactly that. UsingtoStringon a bool returns"1"or""instead.