Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trytond dependencies updates #24827

Merged
merged 3 commits into from May 1, 2017
Merged

Conversation

johbo
Copy link
Contributor

@johbo johbo commented Apr 11, 2017

Motivation for this change

While working on the integration of trytond I have found that some packages need to be updated. I've grouped the updates into this PR.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@johbo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @FRidh to be a potential reviewer.

@johbo
Copy link
Contributor Author

johbo commented Apr 12, 2017

This seems to cause quite a few rebuilds, I guess it's best to re-create against staging.

@FRidh FRidh changed the base branch from master to staging April 12, 2017 10:57
@FRidh FRidh changed the base branch from staging to master April 12, 2017 10:57
@johbo
Copy link
Contributor Author

johbo commented Apr 12, 2017

uh, seems the base branch can be changed, guess it's just a rebase then :D

@FRidh
Copy link
Member

FRidh commented Apr 12, 2017

yes, rebase it yourself to staging. Afterwards, I'll change the merge target here and then its good.

@johbo johbo changed the base branch from master to staging April 12, 2017 11:17
@johbo
Copy link
Contributor Author

johbo commented Apr 12, 2017

I'll try a nox run on my box, but I guess that will run a while :D

@7c6f434c
Copy link
Member

7c6f434c commented May 1, 2017

Now that's a large nox-review run (tried running it, still running, no guarantees that I will finish running it and not give up…)

@FRidh
Copy link
Member

FRidh commented May 1, 2017

@7c6f434c I think we can just go ahead and merge. We can always revert.

@7c6f434c 7c6f434c merged commit 2dd3511 into NixOS:staging May 1, 2017
@7c6f434c
Copy link
Member

7c6f434c commented May 1, 2017

@FRidh this being Python packages (and I am not their maintainer), I would just defer to your judgement if you merged yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants