Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synapse 0.20.0 #24828

Merged
merged 2 commits into from Apr 11, 2017
Merged

Synapse 0.20.0 #24828

merged 2 commits into from Apr 11, 2017

Conversation

fadenb
Copy link
Contributor

@fadenb fadenb commented Apr 11, 2017

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fpletz
Copy link
Member

fpletz commented Apr 11, 2017

In the second commit, a colon is missing after the package name.

@fpletz fpletz merged commit 0f64656 into NixOS:master Apr 11, 2017
@fpletz fpletz deleted the synapse_0.20.0 branch April 11, 2017 23:58
@fadenb fadenb restored the synapse_0.20.0 branch April 12, 2017 19:33
@fadenb fadenb deleted the synapse_0.20.0 branch April 21, 2017 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fadenb @fpletz