Tool: refactor context/expand/implementation in point of traversaling typed defs #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… typed defs In point of traversaling typed defs, context/expand/implementation has duplicate code. This refactored it. Another effect, we can look up context/implementation inside file private classes and defs now.
makenowjust
force-pushed
the
fix/crystal-tool/refactor-type-processor
branch
from
eb62d14
to
f1e0bfd
Compare
|
Thanks @makenowjust 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In point of traversaling typed defs, context/expand/implementation has duplicate code. This PR refactored it.
Another effect, we can look up context/implementation inside file private classes and defs now.