Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tweet-hs: init at 0.5.3.2 #24518

Closed
wants to merge 6 commits into from
Closed

tweet-hs: init at 0.5.3.2 #24518

wants to merge 6 commits into from

Conversation

vmchale
Copy link
Contributor

@vmchale vmchale commented Apr 1, 2017

Motivation for this change

Add tweet-hs executable to nix.

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

matthiasbeyer
matthiasbeyer requested changes Apr 4, 2017
View reviewed changes
Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know whether these changes work, but the commit history is really ugly. Please remove the merge commits and boil this down to two commits (assuming that one needs "madlang" for "tweet-hs").

@vmchale vmchale closed this Apr 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasbeyer matthiasbeyer matthiasbeyer requested changes

Assignees
No one assigned
Labels
12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vmchale @matthiasbeyer @Janik-Haag