Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multimc: 5 -> 0.5.1 #24514

Merged
merged 1 commit into from Apr 1, 2017
Merged

multimc: 5 -> 0.5.1 #24514

merged 1 commit into from Apr 1, 2017

Conversation

cleverca22
Copy link
Contributor

Motivation for this change

the old version was unable to handle new minecraft versions

Things done
  • Tested using sandboxing
    (nix.useSandbox on NixOS,
    or option build-use-sandbox in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@cleverca22, thanks for your PR! By analyzing the history of the files in this pull request, we identified @abbradar, @pSub and @kierdavis to be potential reviewers.

@pSub pSub merged commit ff1d0ce into NixOS:master Apr 1, 2017
@cleverca22 cleverca22 deleted the multimc branch April 1, 2017 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants